Changeset 1259

Timestamp:

05/20/10 20:53:03 (2 years ago)

Author:

gbooker

Message:

Avoid freeing an invalid pointer. Fixes #368

Files:

• trunk/CommonMediaPlayer/Classes/CMPPlayerManager.h (modified) (4 diffs)

trunk/CommonMediaPlayer/Classes/CMPPlayerManager.h

@@ -98 +98 @@
         AuthorizationItem rightSet[] = {{kAuthorizationRightExecute, 0, NULL, 0}};
         AuthorizationRights rights = {1, rightSet};
-        AuthorizationRef auth;
+        AuthorizationRef auth = NULL;
         OSStatus result = AuthorizationCreate(&rights, &environ, kAuthorizationFlagPreAuthorize | kAuthorizationFlagExtendRights, &auth);
         if(result == errAuthorizationSuccess)
@@ -160 +160 @@
                 FrameworkLoadPrint(@"Failed to install Passthrough component");
         }
-        AuthorizationFree(auth, kAuthorizationFlagDefaults);
+        if(auth)
+                AuthorizationFree(auth, kAuthorizationFlagDefaults);
         return success;
 }
@@ -198 +199 @@
                                 AuthorizationItem rightSet[] = {{kAuthorizationRightExecute, 0, NULL, 0}};
                                 AuthorizationRights rights = {1, rightSet};
-                                AuthorizationRef auth;
+                                AuthorizationRef auth = NULL;
                                 OSStatus result = AuthorizationCreate(&rights, &environ, kAuthorizationFlagPreAuthorize | kAuthorizationFlagExtendRights, &auth);
                                 if(result == errAuthorizationSuccess)
@@ -213 +214 @@
                                         FrameworkLoadPrint(@"Failed to correct permissions on Frameworks directory");
                                 }
-                                AuthorizationFree(auth, kAuthorizationFlagDefaults);
+                                if(auth)
+                                        AuthorizationFree(auth, kAuthorizationFlagDefaults);
                                 int status;
                                 wait(&status);