Changeset 1323

Timestamp:

09/18/10 15:15:27 (20 months ago)

Author:

gbooker

Message:

Turned on -Wall and corrected respective warnings.

Location:

trunk/SapphireFrappliance

Files:

• Extension/NSFileManager-Extensions.m (modified) (1 diff)
• MetaDataImporting/SapphireQuickTimeImporter.m (modified) (1 diff)
• MetaDataImporting/SapphireVideoTSParser.m (modified) (2 diffs)
• Sapphire.xcodeproj/project.pbxproj (modified) (1 diff)

trunk/SapphireFrappliance/Extension/NSFileManager-Extensions.m

@@ -28 +28 @@
         if(!([self fileExistsAtPath:proposedPath isDirectory:&isDir]&& isDir))
                 if(![self createDirectoryAtPath:proposedPath attributes:nil])
+                {
                         if([self constructPath:[proposedPath stringByDeletingLastPathComponent]])
                                 return [self createDirectoryAtPath:proposedPath attributes:nil];
                         else
                                 return NO;
+                }
         return YES;     
 }

trunk/SapphireFrappliance/MetaDataImporting/SapphireQuickTimeImporter.m

@@ -134 +134 @@
         BOOL doImport = YES;
         if(type==10)
+        {
                 if([metaData importTypeValue] & ImportTypeMaskTVShow)
                         doImport = NO;
+        }
         else if(type == 9)
+        {
                 if([metaData importTypeValue] & ImportTypeMaskMovie)
                         doImport = NO;
+        }
 
         NSManagedObjectContext *moc = [metaData managedObjectContext];

trunk/SapphireFrappliance/MetaDataImporting/SapphireVideoTSParser.m

@@ -119 +119 @@
         const NSString        *       element    = nil;
         
-        while( element = [enumerator nextObject] )
+        while((element = [enumerator nextObject]) != nil)
                 [str appendFormat:@", %@", element];
         
@@ -186 +186 @@
 
         // The largest IFO file (not including VIDEO_TS.IFO) corresponds to the main feature
-        while( filePath = [enumerator nextObject] )
+        while((filePath = [enumerator nextObject]) != nil)
         {
                 unsigned long long sz = [[[fm fileAttributesAtPath:[videotsPath stringByAppendingPathComponent:filePath] traverseLink:YES] valueForKey:NSFileSize] unsignedLongLongValue];

trunk/SapphireFrappliance/Sapphire.xcodeproj/project.pbxproj

@@ -1832 +1832 @@
                                 SDKROOT = "$(DEVELOPER_SDK_DIR)/MacOSX10.4u.sdk";
                                 SYMROOT = ../build;
+                                WARNING_CFLAGS = "-Wall";
                         };
                         name = Release;