Ticket #126 (closed Enhancement: fixed)
First patch which enables Sapphire in Take2
| Reported by: | stephan | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Other | Version: | |
| Keywords: | Cc: |
Description
Hi,
this is the first patch which adapts 3 files to ATV Take2 (all the stuff was taken from ATVFiles)
- Info.plist
- SapphireAppliance.{h,m}
What it does:
- add some keys to Info.plist
- changed inheritance of SapphireApplicance
- adapted to new protocol
- get around whitelist check
- removed the static bool was checked (was that necessary? why?)
Sapphire now shows up in the main menu, but crashes on startup.
HTH,
Stephan
Attachments
Change History
Changed 5 years ago by Stephan
-
attachment
basic_atv2_changes.patch
added
comment:2 Changed 5 years ago by anonymous
Somehow this part of the patch got lost in Info.plist:
<key>FRAppliancePreferedOrderValue</key>
- <integer>-1</integer>
+ <integer>2</integer>
Maybe this was by purpose, but without this, Sapphire does _not_ show up in the menu.
Cheers, Stephan
comment:3 follow-up: ↓ 4 Changed 5 years ago by gbooker
Is 2 the smallest number? We actually started using -1 for debug purposes, and it was released that way; so we might as well keep using a number which keeps it up at the top.
comment:4 in reply to: ↑ 3 Changed 5 years ago by anonymous
Replying to gbooker:
Is 2 the smallest number? We actually started using -1 for debug purposes, and it was released that way; so we might as well keep using a number which keeps it up at the top.
0 is also working and then it shows up after Movies.
Changed 5 years ago by Stephan
-
attachment
next_step.patch
added
Changes in Info.plist (PrefferedThing?=0), removed debug outputs, fixes SapphireMediaPreview? and SapphireApplicanceController? (to see this, you've to remove allImporter in SapphireApplianceController::recreateMenu)
comment:6 Changed 5 years ago by gbooker
To answer my previous question, after a bunch of learning how the loader works and otool, combined with the usual disassembly, 0.0 is the smallest number accepted by take 2.

patch to enable Sapphire in ATV2 menu