Ticket #126 (closed Enhancement: fixed)

Opened 8 months ago

Last modified 6 months ago

First patch which enables Sapphire in Take2

Reported by: stephan Assigned to:
Priority: normal Milestone:
Component: Other Version:
Keywords: Cc:

Description

Hi,

this is the first patch which adapts 3 files to ATV Take2 (all the stuff was taken from ATVFiles)

  • Info.plist
  • SapphireAppliance.{h,m}

What it does:

  • add some keys to Info.plist
  • changed inheritance of SapphireApplicance
  • adapted to new protocol
  • get around whitelist check
  • removed the static bool was checked (was that necessary? why?)

Sapphire now shows up in the main menu, but crashes on startup.

HTH,
Stephan

Attachments

basic_atv2_changes.patch (9.2 kB) - added by Stephan on 02/20/08 15:32:27.
patch to enable Sapphire in ATV2 menu
next_step.patch (4.4 kB) - added by Stephan on 02/25/08 17:46:11.
Changes in Info.plist (PrefferedThing?=0), removed debug outputs, fixes SapphireMediaPreview? and SapphireApplicanceController? (to see this, you've to remove allImporter in SapphireApplianceController::recreateMenu)

Change History

02/20/08 15:32:27 changed by Stephan

  • attachment basic_atv2_changes.patch added.

patch to enable Sapphire in ATV2 menu

02/20/08 16:53:21 changed by gbooker

(In [494]) Start of Take 2 update; thanks Stephan Refs #126

02/22/08 12:52:53 changed by anonymous

Somehow this part of the patch got lost in Info.plist:

<key>FRAppliancePreferedOrderValue</key>
- <integer>-1</integer>
+ <integer>2</integer>

Maybe this was by purpose, but without this, Sapphire does _not_ show up in the menu.

Cheers, Stephan

(follow-up: ↓ 4 ) 02/22/08 16:58:04 changed by gbooker

Is 2 the smallest number? We actually started using -1 for debug purposes, and it was released that way; so we might as well keep using a number which keeps it up at the top.

(in reply to: ↑ 3 ) 02/25/08 17:40:11 changed by anonymous

Replying to gbooker:

Is 2 the smallest number? We actually started using -1 for debug purposes, and it was released that way; so we might as well keep using a number which keeps it up at the top.

0 is also working and then it shows up after Movies.

02/25/08 17:46:11 changed by Stephan

  • attachment next_step.patch added.

Changes in Info.plist (PrefferedThing?=0), removed debug outputs, fixes SapphireMediaPreview? and SapphireApplicanceController? (to see this, you've to remove allImporter in SapphireApplianceController::recreateMenu)

02/25/08 19:48:22 changed by gbooker

(In [496]) Patch from Stephan again. I changed the int to a real in the info.plist and the padding was too large, so I changed it to a value that is smaller (by half), but still large enough (by examining the classdump offsets). Refs #126

02/25/08 19:49:49 changed by gbooker

To answer my previous question, after a bunch of learning how the loader works and otool, combined with the usual disassembly, 0.0 is the smallest number accepted by take 2.

02/26/08 12:14:42 changed by anonymous

Would it be possible for somebody to post a patched version ready for use for testing purposes?

04/14/08 23:16:36 changed by gbooker

  • status changed from new to closed.
  • resolution set to fixed.

Beta 6 has been released.

Add/Change #126 (First patch which enables Sapphire in Take2)