Ticket #126 (closed Enhancement: fixed)

Opened 7 years ago

Last modified 7 years ago

First patch which enables Sapphire in Take2

Reported by: stephan Owned by:
Priority: normal Milestone:
Component: Other Version:
Keywords: Cc:

Description

Hi,

this is the first patch which adapts 3 files to ATV Take2 (all the stuff was taken from ATVFiles)

  • Info.plist
  • SapphireAppliance.{h,m}

What it does:

  • add some keys to Info.plist
  • changed inheritance of SapphireApplicance
  • adapted to new protocol
  • get around whitelist check
  • removed the static bool was checked (was that necessary? why?)

Sapphire now shows up in the main menu, but crashes on startup.

HTH,
Stephan

Attachments

basic_atv2_changes.patch Download (9.2 KB) - added by Stephan 7 years ago.
patch to enable Sapphire in ATV2 menu
next_step.patch Download (4.4 KB) - added by Stephan 7 years ago.
Changes in Info.plist (PrefferedThing?=0), removed debug outputs, fixes SapphireMediaPreview? and SapphireApplicanceController? (to see this, you've to remove allImporter in SapphireApplianceController::recreateMenu)

Change History

Changed 7 years ago by Stephan

patch to enable Sapphire in ATV2 menu

comment:1 Changed 7 years ago by gbooker

(In [494]) Start of Take 2 update; thanks Stephan Refs #126

comment:2 Changed 7 years ago by anonymous

Somehow this part of the patch got lost in Info.plist:

<key>FRAppliancePreferedOrderValue</key>

  • <integer>-1</integer>
    + <integer>2</integer>

Maybe this was by purpose, but without this, Sapphire does _not_ show up in the menu.

Cheers, Stephan

comment:3 follow-up: ↓ 4 Changed 7 years ago by gbooker

Is 2 the smallest number? We actually started using -1 for debug purposes, and it was released that way; so we might as well keep using a number which keeps it up at the top.

comment:4 in reply to: ↑ 3 Changed 7 years ago by anonymous

Replying to gbooker:

Is 2 the smallest number? We actually started using -1 for debug purposes, and it was released that way; so we might as well keep using a number which keeps it up at the top.

0 is also working and then it shows up after Movies.

Changed 7 years ago by Stephan

Changes in Info.plist (PrefferedThing?=0), removed debug outputs, fixes SapphireMediaPreview? and SapphireApplicanceController? (to see this, you've to remove allImporter in SapphireApplianceController::recreateMenu)

comment:5 Changed 7 years ago by gbooker

(In [496]) Patch from Stephan again. I changed the int to a real in the info.plist and the padding was too large, so I changed it to a value that is smaller (by half), but still large enough (by examining the classdump offsets). Refs #126

comment:6 Changed 7 years ago by gbooker

To answer my previous question, after a bunch of learning how the loader works and otool, combined with the usual disassembly, 0.0 is the smallest number accepted by take 2.

comment:7 Changed 7 years ago by anonymous

Would it be possible for somebody to post a patched version ready for use for testing purposes?

comment:8 Changed 7 years ago by gbooker

  • Status changed from new to closed
  • Resolution set to fixed

Beta 6 has been released.

Note: See TracTickets for help on using tickets.