Ticket #278 (closed Defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Short cast lists causing seg fault

Reported by: wazza Owned by:
Priority: normal Milestone:
Component: Browser Version: 1.0b7
Keywords: Cc:

Description

Some movies can have very short cast lists (especially documentaries). In SapphireMediaPreview a shortend cast list is reduced to 3 for display, but if the original cast list was already less than 3 this causes an array bounds error.

The attached diff fixes the problem.

Platform: Leopard, but probably exists for all
Revision: CoreData branch r.806
To reproduce: Import a documentary ("An inconvenient truth" for example) and scroll down to it in the browser, Sapphire will stall and crash after 2 or 3 seconds.

Attachments

small_cast_segfault.diff Download (716 bytes) - added by wazza 4 years ago.

Change History

Changed 4 years ago by wazza

comment:1 Changed 4 years ago by gbooker

  • Status changed from new to closed
  • Resolution set to fixed

(In [808]) Don't attempt to shorten cast list if it's already short. Fixes #278

Note: See TracTickets for help on using tickets.