Ticket #281 (closed Defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Bug fix: DVD playback not working

Reported by: wazza Owned by:
Priority: normal Milestone:
Component: Playback Version: 1.0b7
Keywords: Cc:

Description

Playback of DVDs does not work on the CoreData branch. The problem is the FILE_CONTAINER_TYPE_VIDEO_TS value is never set for DVDs.

This also means that there is also an issue with recognising DVDs as movies for import. The attached diff fixes both of these problems. The diff also updates the VIDEO_TS parser on the CoreData branch, synched with the version on the trunk.

Attachments

dvd_playback_1.06b7.diff Download (6.9 KB) - added by wazza 6 years ago.
dvd_import_1.0b7 Download (826 bytes) - added by wazza 6 years ago.

Change History

Changed 6 years ago by wazza

comment:1 Changed 6 years ago by wazza

That diff has broken playback of all other files, I'll update with a proper patch later.

comment:2 follow-up: ↓ 4 Changed 6 years ago by gbooker

Wouldn't this be better if the container type were set properly?

comment:3 Changed 6 years ago by gbooker

(In [816]) First pass at setting the file container types Refs #281

comment:4 in reply to: ↑ 2 Changed 6 years ago by wazza

Replying to gbooker:

Wouldn't this be better if the container type were set properly?

I don't mind either way, but I was under the impression that the new NSFileManager APIs obsoleted the FILE_CONTAINER_TYPE_* values, which is why the patch was the way it was. My mistake.

I'll re-run DVDs against the [816] changes and get back to you.

comment:5 Changed 6 years ago by gbooker

The FILE_CONTAINER_TYPE_* values are supposed to be used. It is pure oversight that they were not being set in the first place. It is preferred that selecting the player be done based on these values instead of those in NSFileManager (as they are considerably slower).

comment:6 Changed 6 years ago by wazza

Ok, I'll stick with the version added in [816] then. Playback is working fine, but import is still failing.

I'll have a look later, it's one in the morning here ;-)

Changed 6 years ago by wazza

comment:7 Changed 6 years ago by wazza

Second attachment fixes import. Both import and playback are now ok. Can set to close.

comment:8 Changed 6 years ago by wazza

Oh, and the video_ts pasrer diff in the original attachment is still valid in order to synch with the version on the trunk, otherwise there are possible exceptions

comment:9 Changed 6 years ago by gbooker

(In [821]) Correct importing of VIDEO_TS movies Refs #281

comment:10 Changed 6 years ago by gbooker

  • Status changed from new to closed
  • Resolution set to fixed

(In [822]) Corrected VIDEO_TS parser Fixes #281

Note: See TracTickets for help on using tickets.